Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of MS Excel's LOGNORM.DIST(), NORM.S.DIST(), F.DIST(), GAUSS() and GAMMA() functions #1588

Merged
merged 27 commits into from
Jul 25, 2020
Merged

Implementation of MS Excel's LOGNORM.DIST(), NORM.S.DIST(), F.DIST(), GAUSS() and GAMMA() functions #1588

merged 27 commits into from
Jul 25, 2020

Conversation

MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Jul 18, 2020 •
edited
Loading

This is:

- [ ] a bugfix
- [X] a new feature

Checklist:

Why this change is needed?

Implementation of the Excel LOGNORM.DIST(), NORM.S.DIST(), F.DIST(), GAMMA() and GAUSS() functions; and the additional of unit tests for STANDARDIZE(), NORMSDIST(), and NORMSINV()/NORM.S.INV() functions.

MarkBaker added 6 commits July 18, 2020 11:06
@MarkBaker MarkBaker changed the title Norm s dist with second argument Implementation of MS Excel's NORM.S.DIST() function Jul 18, 2020
@MarkBaker MarkBaker changed the title Implementation of MS Excel's NORM.S.DIST() function Implementation of MS Excel's NORM.S.DIST(), GAUSS() and GAMMA() functions Jul 18, 2020
PowerKiKi
PowerKiKi requested changes Jul 19, 2020
View reviewed changes
Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd exclude doc changes in this PR, assuming it will be solved via #1585.

@MarkBaker MarkBaker force-pushed the NORM-S-DIST-with-second-argument branch from 123a28c to db2ae00 Compare July 20, 2020 17:49
@MarkBaker MarkBaker self-assigned this Jul 20, 2020
@MarkBaker MarkBaker changed the title Implementation of MS Excel's NORM.S.DIST(), GAUSS() and GAMMA() functions Implementation of MS Excel's LOGNORM.DIST(), NORM.S.DIST(), GAUSS() and GAMMA() functions Jul 21, 2020
@MarkBaker MarkBaker changed the title Implementation of MS Excel's LOGNORM.DIST(), NORM.S.DIST(), GAUSS() and GAMMA() functions Implementation of MS Excel's LOGNORM.DIST(), NORM.S.DIST(), F.DIST(), GAUSS() and GAMMA() functions Jul 24, 2020
@MarkBaker MarkBaker merged commit 57213de into master Jul 25, 2020
@MarkBaker MarkBaker deleted the NORM-S-DIST-with-second-argument branch July 25, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PowerKiKi PowerKiKi PowerKiKi requested changes

Assignees

@MarkBaker MarkBaker

Labels
calculation engine testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkBaker @PowerKiKi